Global home currency #301

New issue

Open

opened 2020-12-21 09:31:55 -08:00 by scionaltera · 0 comments

scionaltera commented

2020-12-21 09:31:55 -08:00

(Migrated from github.com)

The current implementation assumes USD is your "default" fiat currency, and uses convertExchangePair() all over the place to make a conversion if the exchange is configured to have a different homeCurrency. It would be a really helpful refactor to be able to set a currency at the top level of the configuration rather than in every exchange. For example:

trading:
  entrySpread: 0.008
  exitTarget: 0.0050
  fixedExposure: 30
  fiatCurrency: EUR # use EUR instead of USD as the default fiat currency
  tradeTimeout: 24

  exchanges:

Setting homeCurrency on an exchange configuration should override the fiatCurrency setting. Without this, non-US users are stuck setting homeCurrency for every single exchange.

The current implementation assumes USD is your "default" fiat currency, and uses `convertExchangePair()` all over the place to make a conversion if the _exchange_ is configured to have a different `homeCurrency`. It would be a really helpful refactor to be able to set a currency at the top level of the configuration rather than in every exchange. For example: ``` trading: entrySpread: 0.008 exitTarget: 0.0050 fixedExposure: 30 fiatCurrency: EUR # use EUR instead of USD as the default fiat currency tradeTimeout: 24 exchanges: ``` Setting `homeCurrency` on an exchange configuration should override the `fiatCurrency` setting. Without this, non-US users are stuck setting `homeCurrency` for every single exchange.

Commenting is not possible because the repository is archived.