scion/arbitrader
Archived
1
0
Fork 0
Code Issues 8 Pull requests 10 Projects Releases Packages Wiki Activity Actions

Divide by zero when scaled long price is near zero #507

New issue
Closed
opened 2022-06-22 14:11:05 -07:00 by scionaltera · 0 comments
scionaltera commented 2022-06-22 14:11:05 -07:00 (Migrated from github.com)
Copy link

I suspect this is due to using a coin that has an actual price close to zero and it gets rounded. The method should protect against divide by zero instead of throwing an exception, but what should the spread be in this case?

https://github.com/agonyforge/arbitrader/blob/master/src/main/java/com/agonyforge/arbitrader/service/SpreadService.java#L172

Screenshot_2022-06-22_at_4 44 57_AM

I suspect this is due to using a coin that has an actual price close to zero and it gets rounded. The method should protect against divide by zero instead of throwing an exception, but what should the spread be in this case? https://github.com/agonyforge/arbitrader/blob/master/src/main/java/com/agonyforge/arbitrader/service/SpreadService.java#L172 ![Screenshot_2022-06-22_at_4 44 57_AM](https://user-images.githubusercontent.com/1952888/175136720-29106607-d74b-4271-b195-0c72f5d28dae.png)
Commenting is not possible because the repository is archived.
No Branch/Tag specified
Branches Tags
master
dependabot/gradle/org.springframework.boot-3.0.5
dependabot/gradle/org.knowm.xchange-xchange-bitstamp-5.1.0
dependabot/gradle/org.knowm.xchange-xchange-stream-kraken-5.1.0
dependabot/gradle/org.knowm.xchange-xchange-poloniex-5.1.0
dependabot/gradle/org.knowm.xchange-xchange-binance-5.1.0
dependabot/gradle/org.knowm.xchange-xchange-stream-gemini-5.1.0
dependabot/gradle/org.knowm.xchange-xchange-bitflyer-5.1.0
dependabot/gradle/org.knowm.xchange-xchange-quoine-5.1.0
dependabot/gradle/org.knowm.xchange-xchange-cexio-5.1.0
dependabot/gradle/org.knowm.xchange-xchange-stream-coinbasepro-5.1.0
bankroll
No results found.
Labels
Clear labels   
blocked
This issue or pull request cannot proceed

  
breaking
This change breaks backward compatibility

  
bug
Something isn't working

  
dependencies
Pull requests that update a dependency file

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
good first issue
Good for newcomers

  
help wanted
Good candidate for contributions

  
question
Looking for community feedback

  
tech debt
Refactors, tests, documentation, etc.

  
testing
Currently performing live testing

  
wontfix
This will not be worked on

No labels
blocked
breaking
bug
dependencies
duplicate
enhancement
good first issue
help wanted
question
tech debt
testing
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
scion/arbitrader#507
No description provided.