Add container support for items #506

Merged

scion merged 10 commits from containers into master 2026-05-31 01:40:53 -07:00

Conversation 0 Commits 10 Files changed 34 +2552 -43

scion commented 2026-05-29 00:53:57 -07:00

Owner

Copy link

Containers are MudItems that can hold other MudItems, similar to
character inventories. Key changes:

Model:

• ItemComponent: added isContainer boolean field (defaults false)
• LocationComponent: added container field (ManyToOne MudItem)
• MudItemRepository: added findByLocationContainer query method

Commands:

• PUT : puts a held item into a held container
• GET : retrieves an item from a held container
• LOOK : shows contents of a held container
• GET (existing ground syntax unchanged)
• OPEN : open a container
• CLOSE : close a container
• LOCK : lock a lockable container
• UNLOCK : unlock a lockable container, if you are also holding its key

All new container code is fully tested with no surviving mutations
outside the benign Spring constructor addSyntax pattern.

Containers are MudItems that can hold other MudItems, similar to character inventories. Key changes: Model: - ItemComponent: added isContainer boolean field (defaults false) - LocationComponent: added container field (ManyToOne MudItem) - MudItemRepository: added findByLocationContainer query method Commands: - PUT <item> <container>: puts a held item into a held container - GET <item> <container>: retrieves an item from a held container - LOOK <container>: shows contents of a held container - GET (existing ground syntax unchanged) - OPEN <item> : open a container - CLOSE <item> : close a container - LOCK <item> : lock a lockable container - UNLOCK <item> : unlock a lockable container, if you are also holding its key All new container code is fully tested with no surviving mutations outside the benign Spring constructor addSyntax pattern.

scion added 1 commit 2026-05-29 00:53:58 -07:00

Add container support for items ... 31a805b596

Containers are MudItems that can hold other MudItems, similar to
character inventories.  Key changes:

Model:
- ItemComponent: added isContainer boolean field (defaults false)
- LocationComponent: added container field (ManyToOne MudItem)
- MudItemRepository: added findByLocationContainer query method

Commands:
- PUT <item> <container>: puts a held item into a held container
- GET <item> <container>: retrieves an item from a held container
- LOOK <container>: shows contents of a held container
- GET (existing ground syntax unchanged)

All new container code is fully tested with no surviving mutations
outside the benign Spring constructor addSyntax pattern.

scion self-assigned this 2026-05-29 00:54:03 -07:00

scion added the

enhancement

label 2026-05-29 00:54:11 -07:00

qwen added 1 commit 2026-05-30 00:31:57 -07:00

Enforce isContainer check in Put, Get, and Look commands ... df6a1b024a

- PutCommand: Rejects putting items into non-container targets with
  '<item> is not a container.' message
- GetCommand: Rejects getting items from non-container sources (FROM path)
  with same error message
- LookCommand: Rejects looking inside non-container items with same error
- Added corresponding tests for non-container rejection in all three commands
- Updated existing tests to explicitly mock isContainer as true for valid
  containers

All mutations for the new guard clauses are killed per Pitest verification.

qwen added 1 commit 2026-05-30 08:19:02 -07:00

Add isContainer toggle to item editor and copy it during buildInstance ... 2e84a857d6

- MudItemTemplate.buildInstance() now copies isContainer from the template
  to the built item instance
- ItemEditorQuestion menu now shows 'Container: true/false' option (C)
  that toggles the isContainer flag on the item prototype
- Added tests for isContainer being copied in buildInstance (both true
  and default false cases)
- Added tests for the editor menu showing isContainer value and the
  toggle working in both directions

qwen added 1 commit 2026-05-30 11:11:08 -07:00

Add OPEN/CLOSE commands and closed container checks ... 106246f27e

- Added canOpen and isOpen boolean fields to ItemComponent with
  getters/setters; both default to false
- Updated MudItemTemplate.buildInstance() to copy canOpen and isOpen
  from template to built instance
- Added 'O' (Openable) toggle to ItemEditorQuestion menu; toggles
  canOpen on the item prototype
- Created OpenCommand: opens a held or ground item; rejects items that
  cannot be opened or are already open
- Created CloseCommand: closes a held or ground item; rejects items that
  cannot be closed or are already closed
- Updated LookCommand: closed containers (canOpen && !isOpen) now show
  '<item> is closed.' instead of listing contents
- Added comprehensive tests for all new functionality

qwen added 1 commit 2026-05-30 19:16:29 -07:00

Add Lock/Unlock commands and item locking functionality ... 74d40102f8

- Add LockCommand and UnlockCommand for locking/unlocking items
- Update OpenCommand to check lock status before opening
- Add locked field to ItemComponent and MudItemTemplate
- Update LookCommand to display lock status
- Update ItemEditorQuestion for locked item editing
- Add corresponding unit tests

scion added 1 commit 2026-05-30 20:08:19 -07:00

Merge branch 'master' into containers 13a9c8b18d

qwen added 1 commit 2026-05-30 20:20:05 -07:00

Update game-object-model docs for container/locking features ... a578916744

- Update ItemComponent description in entity hierarchy table
- Add new fields to ItemComponent schema: isContainer, canOpen, isOpen,
  keyFor, isLocked
- Add section documenting container and locking state, including the
  locking workflow and template-to-instance propagation

scion added 1 commit 2026-05-30 22:58:48 -07:00

tweaks and bugfixes for containers faeeaf19d5

qwen added 1 commit 2026-05-31 00:49:38 -07:00

Make PURGE recursively delete container contents before deleting the container ... 77d9322185

purgeItem now recursively deletes all items inside a container before
deleting the container itself, preventing foreign key constraint violations
on the location_component table.

purgeCharacter drops the character's held items on the ground in their
current room before deleting the character, rather than deleting them.

Added a visited-set guard in purgeItem to prevent infinite recursion if
the database somehow contains a container cycle. Added tests for:
- Nested container recursion (bag > chest > gem)
- Cycle detection (mutually containing containers)
- Character purge dropping held items on the ground

scion added 1 commit 2026-05-31 01:27:22 -07:00

allow GET, LOOK, PUT for containers on the ground, adjust error messaging for commands 15d6fcbaf4

scion changed title from WIP: Add container support for items to Add container support for items 2026-05-31 01:40:32 -07:00

scion merged commit df3f95ebdf into master 2026-05-31 01:40:53 -07:00

scion deleted branch containers 2026-05-31 01:40:53 -07:00

scion referenced this pull request from a commit 2026-05-31 01:40:55 -07:00

Merge pull request 'Add container support for items' (#506) from containers into master

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

bug

Something isn't working

  

dependencies

Pull requests that update a dependency file

  

documentation

Improvements or additions to documentation

  

duplicate

This issue or pull request already exists

  

enhancement

New feature or request

  

good first issue

Good for newcomers

  

help wanted

Extra attention is needed

  

invalid

This doesn't seem right

  

java

Pull requests that update java code

  

question

Further information is requested

  

refactor

Refactor of existing code

  

wontfix

This will not be worked on

No labels

bug

dependencies

documentation

duplicate

enhancement

good first issue

help wanted

invalid

java

question

refactor

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

scion

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

agony-forge/agonyforge!506

No description provided.