Extract LookService from LookCommand and all callers #535

Merged

scion merged 2 commits from refactor/look-service-extraction into master

2026-06-08 13:40:15 -07:00

scion commented

2026-06-08 09:22:27 -07:00

Owner

This change:

Extracts look() and lookContainer() into a new @Service LookService class
with proper Spring DI of RepositoryBundle and SessionAttributeService
Updates all callers (LookCommand, GotoCommand, MoveCommand, TeleportCommand,
TransferCommand, CharacterViewQuestion) to inject LookService via constructor
Removes static doLook/doLookContainer methods from LookCommand
Updates MoveConfiguration to wire LookService into MoveCommand beans
Adds comprehensive unit tests for LookService (room description, HOLYLIGHT
admin info, other characters, items on ground, LINKDEAD flag, container
contents)
Updates all existing command/question tests to mock LookService instead of
calling the removed static methods

LookCommand.doLook() and doLookContainer() were static methods that required passing RepositoryBundle and SessionAttributeService as parameters to every call site. This made the call signature verbose and tightly coupled command classes to infrastructure dependencies. This change: - Extracts look() and lookContainer() into a new @Service LookService class with proper Spring DI of RepositoryBundle and SessionAttributeService - Updates all callers (LookCommand, GotoCommand, MoveCommand, TeleportCommand, TransferCommand, CharacterViewQuestion) to inject LookService via constructor - Removes static doLook/doLookContainer methods from LookCommand - Updates MoveConfiguration to wire LookService into MoveCommand beans - Adds comprehensive unit tests for LookService (room description, HOLYLIGHT admin info, other characters, items on ground, LINKDEAD flag, container contents) - Updates all existing command/question tests to mock LookService instead of calling the removed static methods

scion added 1 commit

2026-06-08 09:22:27 -07:00

Extract LookService from LookCommand and all callers

CI Build & Test / build-and-test (pull_request) Successful in 4m39s

Details

734c6791f0

LookCommand.doLook() and doLookContainer() were static methods that required
passing RepositoryBundle and SessionAttributeService as parameters to every
call site. This made the call signature verbose and tightly coupled command
classes to infrastructure dependencies.

This change:
- Extracts look() and lookContainer() into a new @Service LookService class
  with proper Spring DI of RepositoryBundle and SessionAttributeService
- Updates all callers (LookCommand, GotoCommand, MoveCommand, TeleportCommand,
  TransferCommand, CharacterViewQuestion) to inject LookService via constructor
- Removes static doLook/doLookContainer methods from LookCommand
- Updates MoveConfiguration to wire LookService into MoveCommand beans
- Adds comprehensive unit tests for LookService (room description, HOLYLIGHT
  admin info, other characters, items on ground, LINKDEAD flag, container
  contents)
- Updates all existing command/question tests to mock LookService instead of
  calling the removed static methods

scion added 1 commit

2026-06-08 09:27:36 -07:00

Merge branch 'master' into refactor/look-service-extraction

CI Build & Test / build-and-test (pull_request) Successful in 4m33s

Details

60995038de

scion added 1 commit

2026-06-08 10:46:43 -07:00

suppress warning

CI Build & Test / build-and-test (pull_request) Successful in 4m34s

Details

50b4e02224