Extracted some methods out of TradingService#tick and simplified a bit the flow #242

Merged

dazito merged 4 commits from refactor-trading-service-class into master

2020-10-26 13:08:04 -07:00

dazito commented

2020-10-19 12:33:41 -07:00

(Migrated from github.com)

Removed Map<TradeCombination, BigDecimal> missedTrades

This is WIP - looking forward for your feedback :)

Removed Map<TradeCombination, BigDecimal> missedTrades This is WIP - looking forward for your feedback :)

scionaltera commented

2020-10-20 23:16:45 -07:00

(Migrated from github.com)

I like the direction you're going with this but it's going to take me some time to go through the changes carefully and make sure it didn't introduce any changes to the behavior. Looks good at first glance though!

dazito commented

2020-10-21 11:46:06 -07:00

(Migrated from github.com)

Thanks for the feedback. I will leave it as it is and wait for your feedback 👍

Thanks for the feedback. I will leave it as it is and wait for your feedback :+1:

dazito commented

2020-10-22 13:44:10 -07:00

(Migrated from github.com)

Done with the refactoring. We can still refactor a bit more but for now I think it is ok and also to not overwhelm you with too much to code to review.

Commenting is not possible because the repository is archived.

No reviewers