scion/arbitrader
Archived
1
0
Fork 0
Code Issues 8 Pull requests 10 Projects Releases Packages Wiki Activity Actions

unify active position #283

Merged
scionaltera merged 1 commit from fix-active-position into master 2020-11-25 12:26:16 -08:00
Conversation 0 Commits 1 Files changed 2 +19 -10
scionaltera commented 2020-11-25 00:48:47 -08:00 (Migrated from github.com)
Copy link

Looks like the ActivePosition got split across TradingService and TradingScheduler which is making the behavior of tracking active positions act strangely, especially if you have quit and restarted the program, because it is being tracked independently in two places. This PR moves ownership of the ActivePosition over to TradingService and makes TradingScheduler access it via getter and setter.

Looks like the ActivePosition got split across TradingService and TradingScheduler which is making the behavior of tracking active positions act strangely, especially if you have quit and restarted the program, because it is being tracked independently in two places. This PR moves ownership of the ActivePosition over to TradingService and makes TradingScheduler access it via getter and setter.
👍 1
Commenting is not possible because the repository is archived.
Reviewers
No reviewers
Labels
Clear labels   
blocked
This issue or pull request cannot proceed

  
breaking
This change breaks backward compatibility

  
bug
Something isn't working

  
dependencies
Pull requests that update a dependency file

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
good first issue
Good for newcomers

  
help wanted
Good candidate for contributions

  
question
Looking for community feedback

  
tech debt
Refactors, tests, documentation, etc.

  
testing
Currently performing live testing

  
wontfix
This will not be worked on

No labels
blocked
breaking
bug
dependencies
duplicate
enhancement
good first issue
help wanted
question
tech debt
testing
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
scion/arbitrader!283
No description provided.