Fee computation #295

Merged

scionaltera merged 9 commits from fee-computation into master 2020-12-18 22:13:39 -08:00

Conversation 0 Commits 9 Files changed 34 +818 -102

scionaltera commented 2020-12-17 17:15:28 -08:00 (Migrated from github.com)

Copy link

Adds special logic for exchanges that require their clients to compute fees rather than doing it transparently on the server side. The default is still the original logic but this seems to fix exiting positions on BitFlyer, and possibly Poloniex.

Closes #290
Closes #185

Adds special logic for exchanges that require their clients to compute fees rather than doing it transparently on the server side. The default is still the original logic but this seems to fix exiting positions on BitFlyer, and possibly Poloniex. Closes #290 Closes #185

Commenting is not possible because the repository is archived.

Reviewers

No reviewers

Labels

Clear labels   

blocked

This issue or pull request cannot proceed

  

breaking

This change breaks backward compatibility

  

bug

Something isn't working

  

dependencies

Pull requests that update a dependency file

  

duplicate

This issue or pull request already exists

  

enhancement

New feature or request

  

good first issue

Good for newcomers

  

help wanted

Good candidate for contributions

  

question

Looking for community feedback

  

tech debt

Refactors, tests, documentation, etc.

  

testing

Currently performing live testing

  

wontfix

This will not be worked on

No labels

blocked

breaking

bug

dependencies

duplicate

enhancement

good first issue

help wanted

question

tech debt

testing

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

scion/arbitrader!295

No description provided.