Fix trade log inconsistency when slip occurs #314
No reviewers
Labels
No labels
blocked
breaking
bug
dependencies
duplicate
enhancement
good first issue
help wanted
question
tech debt
testing
wontfix
No milestone
No project
No assignees
1 participant
No due date set.
Dependencies
No dependencies set.
Reference
scion/arbitrader!314
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "trade-logs"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
@ -76,23 +76,27 @@ public class NotificationServiceImpl implements NotificationService {BigDecimal longLimitPrice, BigDecimal shortVolume,Is it important to have the difference and the original amount in the message or would it be sufficient to just replace the difference with the original value?
@ -76,23 +76,27 @@ public class NotificationServiceImpl implements NotificationService {BigDecimal longLimitPrice, BigDecimal shortVolume,I think it would be useful to have both original values (price and volume*price) as the original values are the ones used by the bot to decide to trade or not.
The build failed due to failing unit tests. It looks like you changed the signature of
TradingService.getLimitPrice()but didn't refactor the tests to match.@ -76,23 +76,27 @@ public class NotificationServiceImpl implements NotificationService {BigDecimal longLimitPrice, BigDecimal shortVolume,Sure, I was just thinking we have some redundant information now:Never mind, I wasn't reading carefully enough. I see it now. :)