Enhance paper AccountInfo with balance info + paper trading FeeComputation.CLIENT #338

2021-02-18T02:28:05-08:00

lilianchiassai commented

2021-02-18 02:28:05 -08:00

(Migrated from github.com)

This commit:

enables the FeeComputation.CLIENT exchanges to work with PaperTrading. The calculation is the opposite to the addFees/subtractfees method.
unit tests the PaperTradeService.fillOrder method. The FeeComputation.CLIENT test need real data.
keep track of all the balances of the PaperAccountService, not only the cash balance

This commit: - enables the FeeComputation.CLIENT exchanges to work with PaperTrading. The calculation is the opposite to the addFees/subtractfees method. - unit tests the PaperTradeService.fillOrder method. The FeeComputation.CLIENT test need real data. - keep track of all the balances of the PaperAccountService, not only the cash balance

scionaltera (Migrated from github.com) requested changes

2021-02-18 09:27:24 -08:00

application.example.yaml

				`@ -90,16 +90,20 @@ trading:`

Let's leave this un-commented. It's really easy to scan over it while reading through the example file and not notice that it's an option you can use. Setting the balance to 100 when it's already 100 shouldn't hurt anything.