scion/arbitrader
Archived
1
0
Fork 0
Code Issues 8 Pull requests 10 Projects Releases Packages Wiki Activity Actions

remove assumptions about home currency and currency scales #366

Merged
scionaltera merged 1 commit from remove-account-balance-assumptions into master 2021-03-16 22:30:51 -07:00
Conversation 2 Commits 1 Files changed 4 +41 -49
scionaltera commented 2021-03-16 15:32:46 -07:00 (Migrated from github.com)
Copy link
No description provided.
dazito (Migrated from github.com) approved these changes 2021-03-16 16:00:44 -07:00
src/main/java/com/r307/arbitrader/service/TradingService.java
dazito (Migrated from github.com) commented 2021-03-16 16:00:12 -07:00

We should change this method name because it does not only logs but also get and returns total balance. But maybe we should do this in a separate PR

We should change this method name because it does not only logs but also get and returns total balance. But maybe we should do this in a separate PR
lilianchiassai (Migrated from github.com) approved these changes 2021-03-16 20:22:35 -07:00
Commenting is not possible because the repository is archived.
Reviewers
No reviewers
dazito
lilianchiassai
Labels
Clear labels   
blocked
This issue or pull request cannot proceed

  
breaking
This change breaks backward compatibility

  
bug
Something isn't working

  
dependencies
Pull requests that update a dependency file

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
good first issue
Good for newcomers

  
help wanted
Good candidate for contributions

  
question
Looking for community feedback

  
tech debt
Refactors, tests, documentation, etc.

  
testing
Currently performing live testing

  
wontfix
This will not be worked on

No labels
blocked
breaking
bug
dependencies
duplicate
enhancement
good first issue
help wanted
question
tech debt
testing
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
scion/arbitrader!366
No description provided.