Effective spreads #370

Merged
lilianchiassai merged 9 commits from effective-spreads into master 2021-04-05 16:28:17 -07:00
lilianchiassai commented 2021-03-19 03:35:15 -07:00 (Migrated from github.com)

This changes the configuration from entrySpread / exitTarget to:

  • entrySpreadTarget: the effective spread to meet before entering a trade
  • exitSpreadTarget: the effective spread to meet before closing a trade
  • minimumProfit: the profit in percentage to get before closing a trade. Default to 0.
    If exitSpreadTarget is set, the minimumProfit property is ignored.

We calculate the real entry and exit spread targets from those configurations.

This changes the configuration from entrySpread / exitTarget to: - entrySpreadTarget: the effective spread to meet before entering a trade - exitSpreadTarget: the effective spread to meet before closing a trade - minimumProfit: the profit in percentage to get before closing a trade. Default to 0. If exitSpreadTarget is set, the minimumProfit property is ignored. We calculate the real entry and exit spread targets from those configurations.
dazito (Migrated from github.com) reviewed 2021-03-19 03:35:15 -07:00
scionaltera (Migrated from github.com) reviewed 2021-03-19 13:36:41 -07:00
scionaltera commented 2021-03-19 13:39:07 -07:00 (Migrated from github.com)

I thought of one other thing before we merge; could you please add a version bump since this has breaking changes in the configuration?

I thought of one other thing before we merge; could you please add a version bump since this has breaking changes in the configuration?
scionaltera (Migrated from github.com) approved these changes 2021-04-05 16:24:13 -07:00
Commenting is not possible because the repository is archived.
No description provided.