configurable minimum balances #374

Merged
scionaltera merged 4 commits from ignore-minimum-balances into master 2021-04-03 14:17:13 -07:00
scionaltera commented 2021-04-02 00:22:04 -07:00 (Migrated from github.com)

The feature to prevent Arbitrader from starting if an account has a non-zero crypto balance in it was a good idea but it led me into an impossible situation: my BitFlyer account has 0.00000001 BTC in it, and BitFlyer's minimum trade size is 0.001. I've tried buying crypto and selling all of it to get down to zero and no matter what I do that one last little satoshi remains.

So... I tried making it look at the exchange metadata to figure out the minimum trade size and compare against that instead of zero. Of course the metadata for BitFlyer is missing, so it defaults to zero.

So here we are. I have added a new configuration option that lets you set the minimum allowed balance for a currency on an exchange to whatever you want if the bot won't start because of a tiny bit of crypto you can't seem to get rid of.

The feature to prevent Arbitrader from starting if an account has a non-zero crypto balance in it was a good idea but it led me into an impossible situation: my BitFlyer account has 0.00000001 BTC in it, and BitFlyer's minimum trade size is 0.001. I've tried buying crypto and selling all of it to get down to zero and no matter what I do that one last little satoshi remains. So... I tried making it look at the exchange metadata to figure out the minimum trade size and compare against that instead of zero. Of course the metadata for BitFlyer is missing, so it defaults to zero. So here we are. I have added a new configuration option that lets you set the minimum allowed balance for a currency on an exchange to whatever you want if the bot won't start because of a tiny bit of crypto you can't seem to get rid of.
dazito (Migrated from github.com) reviewed 2021-04-02 16:22:58 -07:00
dazito (Migrated from github.com) left a comment

Just one question to be sure it was not by mistake, otherwise looks good!

Just one question to be sure it was not by mistake, otherwise looks good!
dazito (Migrated from github.com) commented 2021-04-02 16:15:09 -07:00

Was this intentional?

Was this intentional?
scionaltera (Migrated from github.com) reviewed 2021-04-02 17:05:50 -07:00
scionaltera (Migrated from github.com) commented 2021-04-02 17:05:49 -07:00

I believe there was another ‘fee’ element in that same block so I removed the second one.

I believe there was another ‘fee’ element in that same block so I removed the second one.
dazito (Migrated from github.com) reviewed 2021-04-03 04:52:48 -07:00
dazito (Migrated from github.com) commented 2021-04-03 04:52:43 -07:00

In the QuoineExchange example there was only one fee and you removed it

In the `QuoineExchange` example there was only one `fee` and you removed it
scionaltera (Migrated from github.com) reviewed 2021-04-03 14:09:10 -07:00
scionaltera (Migrated from github.com) commented 2021-04-03 14:09:10 -07:00

Ok I’ll put it back. 😬

Ok I’ll put it back. 😬
dazito (Migrated from github.com) approved these changes 2021-04-03 14:14:08 -07:00
Commenting is not possible because the repository is archived.
No description provided.