configurable minimum balances #374
No reviewers
Labels
No labels
blocked
breaking
bug
dependencies
duplicate
enhancement
good first issue
help wanted
question
tech debt
testing
wontfix
No milestone
No project
No assignees
1 participant
Due date
No due date set.
Dependencies
No dependencies set.
Reference
scion/arbitrader!374
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "ignore-minimum-balances"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The feature to prevent Arbitrader from starting if an account has a non-zero crypto balance in it was a good idea but it led me into an impossible situation: my BitFlyer account has 0.00000001 BTC in it, and BitFlyer's minimum trade size is 0.001. I've tried buying crypto and selling all of it to get down to zero and no matter what I do that one last little satoshi remains.
So... I tried making it look at the exchange metadata to figure out the minimum trade size and compare against that instead of zero. Of course the metadata for BitFlyer is missing, so it defaults to zero.
So here we are. I have added a new configuration option that lets you set the minimum allowed balance for a currency on an exchange to whatever you want if the bot won't start because of a tiny bit of crypto you can't seem to get rid of.
Just one question to be sure it was not by mistake, otherwise looks good!
Was this intentional?
I believe there was another ‘fee’ element in that same block so I removed the second one.
In the
QuoineExchangeexample there was only onefeeand you removed itOk I’ll put it back. 😬