Use the CurrencyPairMetaData to find the price scale #391

Merged

scionaltera merged 4 commits from currency-pair-scale into master

2021-05-04 12:57:40 -07:00

scionaltera commented

2021-04-30 11:57:09 -07:00

(Migrated from github.com)

...instead of the CurrencyMetaData which seems to have the wrong values for what we're doing.

This is intended to fix errors that have started to pop up with Kraken saying that we're using the wrong number of decimal places for several currency pairs.

...instead of the CurrencyMetaData which seems to have the wrong values for what we're doing. This is intended to fix errors that have started to pop up with Kraken saying that we're using the wrong number of decimal places for several currency pairs.

dazito (Migrated from github.com) reviewed

2021-04-30 14:10:46 -07:00

scionaltera commented

2021-05-02 00:07:54 -07:00

(Migrated from github.com)

I split up "price" scale and "volume" scale per @AllirionX 's comments on Discord so we're not confusing the two anymore. I also added the same logic into exitPosition() since we're likely to have the same problem with price scale there. Before merging I still want to see it make a successful trade on somebody's machine.

I split up "price" scale and "volume" scale per @AllirionX 's comments on Discord so we're not confusing the two anymore. I also added the same logic into `exitPosition()` since we're likely to have the same problem with price scale there. Before merging I still want to see it make a successful trade on somebody's machine.

lilianchiassai (Migrated from github.com) approved these changes

2021-05-02 03:21:58 -07:00

lilianchiassai (Migrated from github.com) reviewed

2021-05-02 15:06:31 -07:00

lilianchiassai (Migrated from github.com) left a comment

No description provided.

I am getting java.lang.NullPointerException: null at com.r307.arbitrader.service.TradingService.enterPosition(TradingService.java:172)

scionaltera commented

2021-05-02 16:38:49 -07:00

(Migrated from github.com)

I am getting java.lang.NullPointerException: null
at com.r307.arbitrader.service.TradingService.enterPosition(TradingService.java:172)

Yeah, I got that too. I've got a debugger ready to catch it the next time it happens. Not sure how it could be getting a null on that line but I'll figure it out.

> I am getting java.lang.NullPointerException: null > at com.r307.arbitrader.service.TradingService.enterPosition(TradingService.java:172) Yeah, I got that too. I've got a debugger ready to catch it the next time it happens. Not sure how it could be getting a null on that line but I'll figure it out.

dazito (Migrated from github.com) approved these changes

2021-05-04 11:27:37 -07:00

scionaltera commented

2021-05-04 12:57:15 -07:00

(Migrated from github.com)

I got a successful entry running this branch, so I think it's ready to go.

👍 1

Commenting is not possible because the repository is archived.

No reviewers

lilianchiassai

dazito