Use RxJava to create a non blocking pipeline to fetch open orders #410

Merged

dazito merged 8 commits from remove-thread-sleep-when-fetching-open-orders into master

2021-07-02 14:31:07 -07:00

dazito commented

2021-05-13 16:40:43 -07:00

(Migrated from github.com)

Removed the thread sleep when fetching for open orders.
Built a non blocking pipeline using (RxJava) Observables.

Use a flag to control the flow, if we have open orders then we skip any incoming event. Not very happy with this flag approach so any suggestion is very welcome.

Removed the thread sleep when fetching for open orders. Built a non blocking pipeline using (RxJava) Observables. Use a flag to control the flow, if we have open orders then we skip any incoming event. Not very happy with this flag approach so any suggestion is very welcome.

lilianchiassai (Migrated from github.com) reviewed

2021-05-13 16:40:43 -07:00

dazito commented

2021-05-13 16:44:45 -07:00

(Migrated from github.com)

It misses the logging part (calling collectOpenOrders and logging it), I will try to add it tomorrow

It misses the logging part (calling `collectOpenOrders` and logging it), I will try to add it tomorrow

dazito commented

2021-05-14 15:22:01 -07:00

(Migrated from github.com)

Still testing

scionaltera commented

2021-05-26 13:21:41 -07:00

(Migrated from github.com)

I also saw the Trades executed successfully! message before the trades had both filled when I was testing this overnight. I'm experimenting with it a little bit and I'll keep you posted if I figure anything out. It looks good conceptually though.

I also saw the `Trades executed successfully!` message before the trades had both filled when I was testing this overnight. I'm experimenting with it a little bit and I'll keep you posted if I figure anything out. It looks good conceptually though.

scionaltera (Migrated from github.com) reviewed

2021-05-26 13:24:49 -07:00

src/main/java/com/r307/arbitrader/service/TradingService.java