Compatibility with JDK 16 #417

2021-06-02T16:51:48-07:00

scionaltera commented

2021-06-02 16:51:48 -07:00

(Migrated from github.com)

The build was failing when compiled with Java 16. Reported by Blacko on Discord.

Updated Gradle to 7.0.2
Updated Pitest to 1.6.6
Removed stats plugin because latest version doesn't work in Windows
Switched to Palantir's Docker plugin because the old one is no longer maintained
Tested using Amazon Corretto 16 but reverted to 8 after confirming it can work

I'm not ready to increase the required Java version yet, but I'm glad to know that it works in the latest version.

The build was failing when compiled with Java 16. Reported by Blacko on Discord. * Updated Gradle to 7.0.2 * Updated Pitest to 1.6.6 * Removed stats plugin because latest version doesn't work in Windows * Switched to Palantir's Docker plugin because the old one is no longer maintained * Tested using Amazon Corretto 16 but reverted to 8 after confirming it can work I'm not ready to increase the required Java version yet, but I'm glad to know that it works in the latest version.

lilianchiassai (Migrated from github.com) reviewed

2021-06-02 16:51:48 -07:00

dazito (Migrated from github.com) reviewed

2021-06-03 15:26:28 -07:00

build.gradle

					
				@ -103,3 +89,3 @@

				}

				check.dependsOn project.tasks.pitest, project.tasks.dependencyCheckAnalyze, project.tasks.stats

				check.dependsOn project.tasks.pitest, project.tasks.dependencyCheckAnalyze

Why do we need javax.inject? I think we only use spring dependency injection. I know this has been in the build file for quite some time but now that I see it I decided to ask. Maybe we can remove it?

scionaltera (Migrated from github.com) reviewed

2021-07-02 13:55:56 -07:00

build.gradle

					
				@ -103,3 +89,3 @@

				}

				check.dependsOn project.tasks.pitest, project.tasks.dependencyCheckAnalyze, project.tasks.stats

				check.dependsOn project.tasks.pitest, project.tasks.dependencyCheckAnalyze

Honestly I just add it to any Spring project out of habit now, but if I remember correctly without it you can use the @Autowired annotation but not @Inject. If you're using Spring they both do exactly the same thing. I prefer to stick to the platform agnostic annotations when I can even though I know that realistically we're never switching from Spring to anything else in this project. Just personal preference really.

Honestly I just add it to any Spring project out of habit now, but if I remember correctly without it you can use the `@Autowired` annotation but not `@Inject`. If you're using Spring they both do exactly the same thing. I prefer to stick to the platform agnostic annotations when I can even though I know that realistically we're never switching from Spring to anything else in this project. Just personal preference really.